Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: roachtest: port tpcc/mixed-headroom to the new framework #114249

Merged
merged 2 commits into from
Nov 13, 2023
Merged

release-23.2: roachtest: port tpcc/mixed-headroom to the new framework #114249

merged 2 commits into from
Nov 13, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 10, 2023 •
edited by DarrylWong
Loading

Backport 1/1 commits from #113706 on behalf of @DarrylWong.

/cc @cockroachdb/release

Note that the new framework randomizes how many version upgrades occur. This removes the need for both a single upgrade and multiple upgrade test and the two were merged.

Release note: None
Fixes: #110537

Release justification: test only change

@DarrylWong
roachtest: port tpcc/mixed-headroom to the new framework
573bed9 
Note that the new framework randomizes how many version
upgrades occur. This removes the need for both a single
upgrade and multiple upgrade test and the two were merged.

Release note: None
Fixes: #110537
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113706 branch from e2796ad to 9cf2d4d Compare November 10, 2023 18:55
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 10, 2023 18:55
@blathers-crl blathers-crl bot requested review from herkolategan and DarrylWong and removed request for a team November 10, 2023 18:55
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 10, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113706 branch from 8e3bae2 to 573bed9 Compare November 10, 2023 18:55
@blathers-crl blathers-crl bot requested a review from RaduBerinde November 10, 2023 18:55
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Nov 10, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 10, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@DarrylWong
roachtest: bump tpcc/mixed-headroom/n5cpu16 timeout to 6 hours
7ea455e 
The new testing framework used randomizes the amount of times
the TPCC workload is run. Bumping the timeout accounts for the
worst case with 3 upgrades and running TPCC during all finalizations.

Epic: none
Fixes: #114330
Release note: none
@DarrylWong
Copy link
Contributor

Passed on gceworker

TFTR!

@DarrylWong DarrylWong merged commit 1b12b6c into release-23.2 Nov 13, 2023
2 checks passed
@DarrylWong DarrylWong deleted the blathers/backport-release-23.2-113706 branch November 13, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatolabs renatolabs renatolabs approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan was automatically assigned from cockroachdb/test-eng

@DarrylWong DarrylWong Awaiting requested review from DarrylWong DarrylWong was automatically assigned from cockroachdb/test-eng

@RaduBerinde RaduBerinde Awaiting requested review from RaduBerinde

@srosenberg srosenberg Awaiting requested review from srosenberg

Assignees

@DarrylWong DarrylWong

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @DarrylWong @renatolabs