clusterversion: rename latest/min supported versions in Handle #113727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
RaduBerinde
force-pushed
the
version-cleanup-2
branch
2 times, most recently
from
88fd043 to
0dcacbd
Compare
RaduBerinde
requested review from
itsbilal,
dt and
dhartunian
and removed request for
a team
andyyang890
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Reviewed 36 of 36 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @dhartunian, @dt, @itsbilal, and @RaduBerinde)
pkg/clusterversion/clusterversion.go line 14 at r1 (raw file):
// versions in order to accommodate backward incompatible behaviors. It handles // the feature gates and so must maintain a fairly lightweight set of // dependencies. The upgrade sub-package handles advancing a cluster from one
nit: s/sub-package/package/
RaduBerinde
force-pushed
the
version-cleanup-2
branch
from
0dcacbd to
93ee559
Compare
RaduBerinde
commented
Nov 3, 2023
There was a problem hiding this comment.
TFTR!
Reviewable status:
Rename "binary version" to "latest version" and "binary min supported version" to "min supported version" in `clusterversion.Handle` and associated code. Informs: cockroachdb#112629 Release note: None
RaduBerinde
force-pushed
the
version-cleanup-2
branch
from
93ee559 to
82d5721
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename "binary version" to "latest version" and "binary min supported
version" to "min supported version" in
clusterversion.Handleandassociated code.
This change is mechanical and is not intended to have any functional changes.
Informs: #112629
Release note: None