Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: roachtest: port import/mixed-versions to the new framework #113630

Merged
merged 1 commit into from
Nov 3, 2023
Merged

release-23.2: roachtest: port import/mixed-versions to the new framework #113630

merged 1 commit into from
Nov 3, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 1, 2023 •
edited by yuzefovich
Loading

Backport 1/1 commits from #113546 on behalf of @yuzefovich.

/cc @cockroachdb/release

Fixes: #110529.

Release note: None

Release justification: test-only change.

@yuzefovich
roachtest: port import/mixed-versions to the new framework
39855f7 
There are some minor differences:
- we no longer install fixtures (which weren't used anyway)
- we'll probably run the IMPORT multiple times throughout the test run.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 1, 2023 20:40
@blathers-crl blathers-crl bot removed the request for review from a team November 1, 2023 20:40
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113546 branch from 9f2d988 to f41df02 Compare November 1, 2023 20:40
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 1, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113546 branch from e57f74b to 39855f7 Compare November 1, 2023 20:40
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Nov 1, 2023 •
edited by yuzefovich
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 1, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

renatolabs
renatolabs approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@renatolabs renatolabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, we can (should?) also backport this to 23.1.

mgartner
mgartner approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yuzefovich yuzefovich merged commit a0c0504 into release-23.2 Nov 3, 2023
2 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-23.2-113546 branch November 3, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatolabs renatolabs renatolabs approved these changes

@mgartner mgartner mgartner approved these changes

@DrewKimball DrewKimball Awaiting requested review from DrewKimball

Assignees

@yuzefovich yuzefovich

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @mgartner @renatolabs @yuzefovich