release-23.2: bincheck: bind 127.0.0.1 #113526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #113502 on behalf of @rail.
/cc @cockroachdb/release
Previously, bincheck started a single node database instance without specifying the address/port it listens on. In this case the server code tried to resolve the hostname and use it. See
cockroach/pkg/base/addr_validation.go
Line 128 in d498a59
At some point this method stopped working on MacOS GitHub workers. There is an upstream issue open: actions/runner-images#8649
This PR explicitly sets the
--listen-addr
parameter to skip the problematic code.Epic: none
Release note: None
Release justification: release automation changes