release-23.2: storage: restore optimization for inline puts/deletes #113510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #112586.
/cc @cockroachdb/release
We had an optimization that avoided constructing an iterator over the locktable key space when doing inline puts/deletes. This was lost in ac14ebb that constructed a lockTableKeyScanner even for inline puts/deletes. The optimization is restored here to fix the regression discussed in #111919 (comment).
Informs #111919
Epic: none
Release note: None
Release justification: Low risk fix to performance regression.