Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: always START SERVICE SHARED in testserver.StartSharedProcessTenant() #111603

Merged

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Oct 2, 2023

Previously, StartSharedProcessTenant() would hang if it were run on a tenant that was created by a replication stream. This patch fixes this bug by ensuring ALTER TENANT $1 START SERVICE SHARED is run even if the tenant was already created.

Epic: none

Release note: None

Previously, StartSharedProcessTenant() would hang if it were run on a tenant
that was created by a replication stream. This patch fixes this bug by ensuring
`ALTER TENANT $1 START SERVICE SHARED` is run even if the tenant was already
created.

Epic: none

Release note: None
@msbutler msbutler self-assigned this Oct 2, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler msbutler changed the title server: always START SERVICE SHARED in StartSharedProcessTenant() server: always START SERVICE SHARED in testserver.StartSharedProcessTenant() Oct 2, 2023
@msbutler msbutler marked this pull request as ready for review October 2, 2023 19:23
@msbutler msbutler requested review from a team as code owners October 2, 2023 19:23
@msbutler msbutler requested review from herkolategan, renatolabs, knz and a team and removed request for a team and renatolabs October 2, 2023 19:23
@msbutler
Copy link
Collaborator Author

msbutler commented Oct 2, 2023

This patch allows the test in #111578 to pass.

@msbutler
Copy link
Collaborator Author

msbutler commented Oct 2, 2023

TFTR!

bors r=knz

@craig
Copy link
Contributor

craig bot commented Oct 2, 2023

Build succeeded:

@craig craig bot merged commit 422b70f into cockroachdb:master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants