sql: fix bug when dropping enum value when used in ARRAY column #111354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Xiang-Gu
force-pushed
the
bug/drop-enum-value-used-in-array-col
branch
from
fc0941c to
202fbd9
Compare
fqazi
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Nice find!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Xiang-Gu)
-- commits line 8 at r1:
Should this have a release note? This sounds like a user-facing bug
Previously, if an enum value is been used at least twice in a ARRAY column in a table, attempts to drop that enum value results in a wrong error message. This PR fixes that. Release note (bug fix): Fix the error message when we attempt to drop an enum value that is used at least twice in an ARRAY column.
Xiang-Gu
force-pushed
the
bug/drop-enum-value-used-in-array-col
branch
from
202fbd9 to
848327c
Compare
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an enum value had been used at least twice in an ARRAY column in a table, attempts to drop that enum value resulted in a wrong error message. This PR fixes that.
Epic: None
Fix #110827
Release note: None