util/tracing: remove the jaeger exporter #111342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knz
requested review from
a team and
Santamaura
and removed request for
a team
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
knz
force-pushed
the
20230927-jaeger
branch
from
6bc9625 to
0b2a9af
Compare
abarganier
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @knz and @Santamaura)
-- commits line 13 at r1:
nit: s/OLTP/OTLP
-- commits line 81 at r1:
nit: "Release note" already given up top?
Release note (backward-incompatible change): The direct export of
traces to Jaeger and the cluster setting `trace.jaeger.agent` have
been removed. The direct export functionality had been obsoleted since
2022; it stopped working altogether some time in 2023 with the
following error:
```
data does not fit within one UDP packet; size 65006, max 65000, spans NN
```
Since 2022, Jaeger supports ingestion of traces using OTLP; and
CockroachDB has supported emitting traces using OTLP since v22.1.
Operators and developers who want to inspect traces are thus invited
to use the OTLP protocol instead. The corresponding cluster setting is
`trace.opentelemetry.collector`.
For a successful deployment, an intermediate OTLP collector/forwarder
should be configured. This docker-compose configuration is suitable:
```yaml
otel-collector:
image: otel/opentelemetry-collector-contrib
container_name: otel-collector
volumes:
- ./otel-collector-config.yaml:/etc/otelcol-contrib/config.yaml
ports:
- 1888:1888 # pprof extension
- 8888:8888 # Prometheus metrics exposed by the collector
- 8889:8889 # Prometheus exporter metrics
- 13133:13133 # health_check extension
- 4317:4317 # OTLP gRPC receiver
- 4318:4318 # OTLP http receiver
- 55679:55679 # zpages extension
jaeger:
image: jaegertracing/all-in-one
container_name: jaeger
ports:
- "16685:16685"
- "16686:16686"
- "14250:14250"
- "14268:14268"
- "14269:14269"
- "6831:6831/udp"
environment:
- COLLECTOR_ZIPKIN_HTTP_PORT=9411
- COLLECTOR_OTLP_ENABLED=true
```
Together with the following otel-collector configuration:
```yaml
receivers:
otlp: # the OTLP receiver the app is sending traces to
protocols:
grpc:
http:
processors:
batch:
exporters:
otlp/jaeger: # Jaeger supports OTLP directly
endpoint: http://jaeger:4317
tls:
insecure: true
service:
pipelines:
traces/dev:
receivers: [otlp]
processors: [batch]
exporters: [otlp/jaeger]
```
To use this, unset jaeger `SET CLUSTER SETTING trace.jaeger.agent=''`
then set the OTLP collector using `SET CLUSTER SETTING
trace.opentelemetry.collector='localhost:4317'`.
knz
commented
Oct 2, 2023
There was a problem hiding this comment.
Reviewable status:
Previously, abarganier (Alex Barganier) wrote…
nit: s/OLTP/OTLP
Done
Previously, abarganier (Alex Barganier) wrote…
nit: "Release note" already given up top?
Removed
|
TFYR! bors r=abarganier |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110632.
Epic: CRDB-28893
Many thanks to @maxnilz for their suggestions.
Release note (backward-incompatible change): The direct export of traces to Jaeger and the cluster setting
trace.jaeger.agenthave been removed. The direct export functionality had been obsoleted since 2022; it stopped working altogether some time in 2023 with the following error:Since 2022, Jaeger supports ingestion of traces using OLTP; and CockroachDB has supported emitting traces using OLTP since v22.1. Operators and developers who want to inspect traces are thus invited to use the OLTP protocol instead. The corresponding cluster setting is
trace.opentelemetry.collector.For a successful deployment, an intermediate OLTP collector/forwarder should be configured. This docker-compose configuration is suitable:
Together with the following otel-collector configuration:
To use this, unset jaeger
SET CLUSTER SETTING trace.jaeger.agent=''then set the OLTP collector usingSET CLUSTER SETTING trace.opentelemetry.collector='localhost:4317'.Release note: None