Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix flaky job profiler tests #111220

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

adityamaru
Copy link
Contributor

The terminal trace is dumped after the job's status is updated. In some tests we need to rerty a few times before the file shows up in the job_info table.

Fixes: #111117
Fixes: #111013

Release note: None

The terminal trace is dumped after the job's status
is updated. In some tests we need to rerty a few times before
the file shows up in the job_info table.

Fixes: cockroachdb#111117
Fixes: cockroachdb#111013

Release note: None
@adityamaru adityamaru requested a review from msbutler September 25, 2023 17:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adityamaru
Copy link
Contributor Author

bors r+ p=999 single on

@craig
Copy link
Contributor

craig bot commented Sep 25, 2023

Build succeeded:

@craig craig bot merged commit 967fe5e into cockroachdb:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: flake in TestReadWriteProfilerExecutionDetails sql: TestListProfilerExecutionDetails failed
3 participants