roachtest: add admission-overload/follower-overload #111070
Conversation
irfansharif
requested review from
bananabrick,
aadityasondhi and
sumeerbhola
irfansharif
requested review from
rachitgsrivastava and
smg260
and removed request for
a team
|
This change is |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aadityasondhi, @bananabrick, @irfansharif, @rachitgsrivastava, and @smg260)
-- commits line 7 at r1:
nit: The tests add an ...
-- commits line 13 at r1:
nit: if the concentrated follower node also serves some ...
pkg/cmd/roachtest/tests/admission_control_follower_overload.go line 119 at r1 (raw file):
// cluster every time. const dev = true if dev {
nit: why this if-block if dev is always true?
aadityasondhi
force-pushed
the
230921.ac-follower-overload
branch
3 times, most recently
from
937348d to
7e01e05
Compare
There was a problem hiding this comment.
Reviewable status:
Previously, sumeerbhola wrote…
nit: The tests add an ...
Fixed.
Previously, sumeerbhola wrote…
nit: if the concentrated follower node also serves some ...
Fixed.
pkg/cmd/roachtest/tests/admission_control_follower_overload.go line 119 at r1 (raw file):
Previously, sumeerbhola wrote…
nit: why this if-block if
devis always true?
I'm not sure; it came from the original PR. I removed it.
|
bors r=sumeerbhola |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
bors r- |
|
Canceled. |
aadityasondhi
force-pushed
the
230921.ac-follower-overload
branch
2 times, most recently
from
baacc66 to
1e716fd
Compare
This is just resuscitating cockroachdb#81516, tests we added when developing follower pausing but never checked in. Some of this work is applicable in the context of replication admission control, when we apply flow control for regular writes. The tests add an IO nemesis on n3/s3, restricting disk bandwidth to 20MiB/s. They then observe what happens when remote nodes n1 and n2 issue follower write traffic to it, either across many ranges or just 1 (potentially triggering the per-replica proposal quota pool). We can observe LSM state on n3/s3 under such conditions, and also what would happen if the concentrated follower node also serves some foreground load. Part of cockroachdb#89208. Release note: None
aadityasondhi
force-pushed
the
230921.ac-follower-overload
branch
from
1e716fd to
ca1a6d6
Compare
|
bors r=sumeerbhola |
|
Build failed (retrying...): |
|
Build succeeded: |
This is just resuscitating #81516, tests we added when developing
follower pausing but never checked in. Some of this work is applicable
in the context of replication admission control, when we apply flow
control for regular writes. The tests add an IO nemesis on n3/s3,
restricting disk bandwidth to 20MiB/s. They then observe what happens
when remote nodes n1 and n2 issue follower write traffic to it, either
across many ranges or just 1 (potentially triggering the per-replica
proposal quota pool). We can observe LSM state on n3/s3 under such
conditions, and also what would happen if the concentrated follower node
also serves some foreground load.
Part of #89208.
Release note: None