kvserver: get Stats and GCHint under same RLock #110652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, makeMVCCGCQueueScore unlocked Replica.mu between reading ReplicaState.Stats and ReplicaState.GCHint. The GC scoring function uses both fields, we would like them to be in sync. The unlock makes it possible for Stats and GCHint to correspond to different states of the Replica. This commit moves both reads under the same RLock/RUnlock. Epic: none Release note: none
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
pav-kv
commented
Sep 14, 2023
|
bors r=erikgrinaker |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
makeMVCCGCQueueScoreunlockedReplica.mubetween readingReplicaState.StatsandReplicaState.GCHint. The GC scoring function uses both fields, we would like them to be in sync. The unlock makes it possible forStatsandGCHintto correspond to different states of theReplica.This commit moves both reads under the same
RLock/RUnlock.Epic: none
Release note: none