externalconn/testutils: fix a mistake in SetSQLDBForUser #110005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
Before this patch, the DefaultZoneConfig field was taken from the global default. This is incorrect. This patch fixes it. Note that this patch is not complete - we also need to update the non-test version of tenant configs, by communicating the default config from the KV layer to the SQL service over the network (using tenant connector). Release note: None
Release note: None
knz
requested review from
rharding6373,
srosenberg and
renatolabs
and removed request for
a team
|
This change is |
stevendanna
approved these changes
Sep 5, 2023
Prior to this patch, this method was incorrectly swapping a SQL connection to the secondary tenant for one to the system tenant. This patch fixes it. Note: the problem was "invisible" because this incorrect redirect was the first thing that ever happened in any data file to a secondary tenant. So really all the "multi-tenant" testdata files were really exercising the system tenant. Release note: None
Done. (added to commit message)
Done - it's unaffected because it does not contain a SetSQLDBForUser method. |
knz
force-pushed
the
20230905-externalconn-fix
branch
from
e16128a to
547a048
Compare
|
TFYR! bors r=stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All commits but the last are from #110004 (review only the last commit here)
Prior to this patch, this method was incorrectly swapping a SQL
connection to the secondary tenant for one to the system tenant.
This patch fixes it.
Epic: CRDB-18499