-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1.9-rc: schematelemetry: emit metrics and logs about invalid objects #109739
Merged
rafiss
merged 1 commit into
release-23.1.9-rc
from
blathers/backport-release-23.1.9-rc-109733
Aug 31, 2023
Merged
release-23.1.9-rc: schematelemetry: emit metrics and logs about invalid objects #109739
rafiss
merged 1 commit into
release-23.1.9-rc
from
blathers/backport-release-23.1.9-rc-109733
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1.9-rc-109733
branch
from
August 30, 2023 17:29
efe33a4
to
0f0e6ed
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Aug 30, 2023
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1.9-rc-109733
branch
from
August 30, 2023 17:29
4c02133
to
f2cec31
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Aug 30, 2023
rafiss
changed the title
release-23.1.9-rc: release-23.1: schematelemetry: emit metrics and logs about invalid objects
release-23.1.9-rc: schematelemetry: emit metrics and logs about invalid objects
Aug 30, 2023
andyyang890
approved these changes
Aug 30, 2023
Short of continuously polling `crdb_internal.invalid_objects`, there was not a convenient way to monitor a cluster for descriptor corruption. Having such an indicator would allow customers to perform preflight checks ahead of upgrades to avoid being stuck in a mixed version state. It would also allow CRL to more easily monitor cloud clusters for corruptions in the wild. This commit updates the schematelemetry job to additionally update the `sql.schema.invalid_objects` gauge and emit logs for any encountered corruptions. Informs: #104266 Epic: CRDB-28665 Release note (ops change): Added a new sql.schema.invalid_objects gauge metric. This gauge is periodically updated based on the schedule set by the sql.schema.telemetry.recurrence cluster setting. When it is updated, it counts the number of schema objects (tables, types, schemas, databases, and functions) that are in an invalid state according to CockroachDB’s internal validation checks. This metric is expected to be zero in a healthy cluster, and if it is not, it indicates that there is a problem that must be repaired.
rafiss
force-pushed
the
blathers/backport-release-23.1.9-rc-109733
branch
from
August 30, 2023 18:46
f2cec31
to
886dc64
Compare
rafiss
requested review from
a team and
Santamaura
and removed request for
a team
August 30, 2023 18:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #108559 on behalf of @chrisseto.
/cc @cockroachdb/release
Short of continuously polling
crdb_internal.invalid_objects
, there was not a convenient way to monitor a cluster for descriptor corruption.Having such an indicator would allow customers to perform preflight checks ahead of upgrades to avoid being stuck in a mixed version state. It would also allow CRL to more easily monitor cloud clusters for corruptions in the wild.
This commit updates the schematelemetry job to additionally update the
sql.schema.invalid_objects
gauge and emit logs for any encountered corruptions.Informs: #104266
Epic: CRDB-28665
Release note (ops change): Added a new sql.schema.invalid_objects gauge
metric. This gauge is periodically updated based on the schedule set by
the sql.schema.telemetry.recurrence cluster setting. When it is updated,
it counts the number of schema objects (tables, types, schemas, databases,
and functions) that are in an invalid state according to CockroachDB’s
internal validation checks. This metric is expected to be zero in a healthy
cluster, and if it is not, it indicates that there is a problem that must
be repaired.
Release justification: low risk addition to metrics