Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror: add logging for go errors #109478

Merged
merged 1 commit into from
Aug 25, 2023
Merged

mirror: add logging for go errors #109478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pkg/cmd/mirror/go/mirror.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,12 @@ func downloadZips(
cmd.Dir = tmpdir
jsonBytes, err := cmd.Output()
if err != nil {
return nil, err
var stderr []byte
if exitErr := (*exec.ExitError)(nil); errors.As(err, &exitErr) {
stderr = exitErr.Stderr
}
return nil, fmt.Errorf("failed to run go with arguments %+v; got stdout %s, stderr %s; %w",
downloadArgs, string(jsonBytes), string(stderr), err)
}
var jsonBuilder strings.Builder
ret := make(map[string]downloadedModule)
Expand All @@ -184,7 +189,12 @@ func listAllModules(tmpdir string) (map[string]listedModule, error) {
cmd.Dir = tmpdir
jsonBytes, err := cmd.Output()
if err != nil {
return nil, err
var stderr []byte
if exitErr := (*exec.ExitError)(nil); errors.As(err, &exitErr) {
stderr = exitErr.Stderr
}
return nil, fmt.Errorf("failed to run `go list -mod=readonly -m -json all`; got stdout %s, stderr %s; %w",
string(jsonBytes), string(stderr), err)
}
ret := make(map[string]listedModule)
var jsonBuilder strings.Builder
Expand Down