Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: show warning when data is not old enough #109468

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

maryliag
Copy link
Contributor

Backport 1/1 commits from #109164.

/cc @cockroachdb/release


If a user selects a time period that we don't have the data for it (because it was already cleaned),
we show a warning to indicate the data might not be complete.

Fix #108989

Screenshot 2023-08-23 at 5 30 18 PM

https://www.loom.com/share/a7e0b0738d834bb0b6f38a9da43fb6a4

Release note (ui change): Show warning when time period selected on SQL Activity is older than the oldest data available.


Release justification: UX improvement

If a user selects a time period that we don't have
the data for it (because it was already cleaned),
we show a warning on SQL Activity (Statement and Transactions)
to indicate the data might not be complete.

Fix cockroachdb#108989

Release note (ui change): Show warning when time period selected
on SQL Activity is older than the oldest data available.
@maryliag maryliag requested a review from a team August 24, 2023 21:26
@blathers-crl
Copy link

blathers-crl bot commented Aug 24, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Aug 24, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag requested a review from a team August 25, 2023 03:19
Copy link
Contributor

@gtr gtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@maryliag maryliag merged commit f2db522 into cockroachdb:release-23.1 Aug 25, 2023
@maryliag maryliag deleted the backport23.1-109164 branch August 25, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants