Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authserver: clarify a skip #109239

Merged
merged 1 commit into from
Aug 22, 2023
Merged

authserver: clarify a skip #109239

merged 1 commit into from
Aug 22, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Aug 22, 2023 •
edited
Loading

Release note: None
Epic: CRDB-28893

@knz
authserver: clarify a skip
f25d0fc 
Release note: None
@knz knz requested a review from ericharmeling August 22, 2023 14:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

ericharmeling
ericharmeling approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification 😄 !

@knz
Copy link
Contributor Author

knz commented Aug 22, 2023

bors r=ericharmeling

@craig
Copy link
Contributor

craig bot commented Aug 22, 2023

Build succeeded:

@craig craig bot merged commit 33d6552 into cockroachdb:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharmeling ericharmeling ericharmeling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knz @cockroach-teamcity @ericharmeling