tests: roachtest that creates overload when doing intent resolution #108916
Conversation
sumeerbhola
requested review from
herkolategan and
DarrylWong
and removed request for
a team
|
This change is |
|
ignore the first commit -- it is from #108873 |
|
L0 sublevels goes over the threshold due to the lack of AC |
| Timeout: time.Hour, | ||
| Benchmark: true, | ||
| Tags: registry.Tags(`weekly`), | ||
| // Second node is solely for Prometheus. |
There was a problem hiding this comment.
We don't need to BTW - even running prometheus on the same node, or not at all, is ok. These runs happen on GCE and we now have that global prometheus instance that knows how to scrape every endpoint.
| Owner: registry.OwnerAdmissionControl, | ||
| Timeout: time.Hour, | ||
| Benchmark: true, | ||
| Tags: registry.Tags(`weekly`), |
There was a problem hiding this comment.
Run nightly for a while to shake out flakes before reducing to weekly frequency?
There was a problem hiding this comment.
TFTR!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @DarrylWong, @herkolategan, and @irfansharif)
pkg/cmd/roachtest/tests/admission_control_intent_resolution.go line 39 at r2 (raw file):
Previously, irfansharif (irfan sharif) wrote…
Run nightly for a while to shake out flakes before reducing to weekly frequency?
Done
pkg/cmd/roachtest/tests/admission_control_intent_resolution.go line 40 at r2 (raw file):
Previously, irfansharif (irfan sharif) wrote…
We don't need to BTW - even running prometheus on the same node, or not at all, is ok. These runs happen on GCE and we now have that global prometheus instance that knows how to scrape every endpoint.
I added this only because someone could do --cloud aws. I've left this unchanged.
sumeerbhola
force-pushed
the
intent_roachtest
branch
from
ee2f24d to
d973f6a
Compare
Informs cockroachdb#97108 Epic: CRDB-25458 Release note: None
sumeerbhola
force-pushed
the
intent_roachtest
branch
from
d973f6a to
8f401f6
Compare
|
bors r=irfansharif |
|
Build succeeded: |
Informs #97108
Epic: CRDB-25458
Release note: None