Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: util/log: allow custom crash report tags #108915

Closed
wants to merge 1 commit into from
Closed

release-23.1: util/log: allow custom crash report tags #108915

wants to merge 1 commit into from

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 17, 2023

Backport 1/1 commits from #106786 on behalf of @pjtatlow.

/cc @cockroachdb/release

Today it can be difficult to trace back a sentry event to the CC cluster where
it originated, especially for serverless clusters. This change enables a new
environment variable (COCKROACH_CRASH_REPORT_TAGS), which allows
the database operator to provide additional information that will be included
in the sentry event.

Release Note: None

Release justification:

util/log: allow custom crash report tags
bd6dfc4 
Today it can be difficult to trace back a sentry event to the CC cluster where
it originated, especially for serverless clusters. This change enables a new
environment variable (COCKROACH_CRASH_REPORT_TAGS), which allows
the database operator to provide additional information that will be included
in the sentry event.

Release note: None

Epic: none
@blathers-crl blathers-crl bot requested review from a team and dhartunian and removed request for a team August 17, 2023 16:06
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label Aug 17, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106786 branch from abb42a1 to 2c16b88 Compare August 17, 2023 16:06
@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label Aug 17, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106786 branch from b9e1d47 to bd6dfc4 Compare August 17, 2023 16:06
@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 17, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from jeffswenson and pjtatlow August 17, 2023 16:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jaylim-crl
Copy link
Collaborator

I'm going to close this for now. Looks like we added getTagsFromEnvironment but we didn't invoke it.

@jaylim-crl jaylim-crl closed this Aug 17, 2023
@jaylim-crl jaylim-crl deleted the blathers/backport-release-23.1-106786 branch August 17, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhartunian dhartunian Awaiting requested review from dhartunian

@jeffswenson jeffswenson Awaiting requested review from jeffswenson

@pjtatlow pjtatlow Awaiting requested review from pjtatlow

Assignees

@pjtatlow pjtatlow

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @jaylim-crl @pjtatlow