Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: make tests work offline #108906

Merged

Conversation

jayshrivastava
Copy link
Contributor

@jayshrivastava jayshrivastava commented Aug 17, 2023

This change updates two unit tests to pass when
running offline.

Fixes: #108867
Release note: None
Epic: None

This change updates two unit tests to pass when
running offline.

Fixes: cockroachdb#108867
Release note: None
Epic: None
@jayshrivastava jayshrivastava marked this pull request as ready for review August 17, 2023 14:00
@jayshrivastava jayshrivastava requested a review from a team as a code owner August 17, 2023 14:00
@jayshrivastava jayshrivastava requested review from HonoreDB and removed request for a team August 17, 2023 14:00
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jayshrivastava
Copy link
Contributor Author

bors r=miretskiy

@craig
Copy link
Contributor

craig bot commented Aug 17, 2023

Build succeeded:

@craig craig bot merged commit 8d5ff3f into cockroachdb:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccl/changefeedccl: unit tests fail if no network acces
3 participants