Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sqlsmith: disable NAME type in postgres mode #108826

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 16, 2023

Backport 1/1 commits from #108811 on behalf of @msirek.

/cc @cockroachdb/release


The NAME type is known to have different behavior in CRDB than in postgres, in that casting to name truncates a string to 63 characters in postgres, but not in CRDB, causing sqlsmith test failures. For backwards compatibility, CRDB behavior is not being changed to match postgres, at least for now.

The fix is to prevent sqlsmith tests which use postgres mode (which implies it is comparing CRDB results with postgres) from generating NAME as a random type for testing.

Fixes: #107895

Release note: None


Release justification: Test-only fix for test vision zero

The NAME type is known to have different behavior in CRDB than in
postgres, in that casting to name truncates a string to 63 characters in
postgres, but not in CRDB, causing sqlsmith test failures. For backwards
compatibility, CRDB behavior is not being changed to match postgres,
at least for now.

The fix is to prevent sqlsmith tests which use postgres mode (which
implies it is comparing CRDB results with postgres) from generating NAME
as a random type for testing.

Fixes: #107895

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner August 16, 2023 04:27
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-108811 branch from 6bcaf00 to a43e74c Compare August 16, 2023 04:27
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 16, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-108811 branch from 35b347f to 1096e05 Compare August 16, 2023 04:27
@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 16, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from michae2 and msirek August 16, 2023 04:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msirek msirek merged commit 6e1aee4 into release-22.2 Aug 16, 2023
@msirek msirek deleted the blathers/backport-release-22.2-108811 branch August 16, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants