Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: roachtest: deflake npgsql test #108578

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 11, 2023

Backport 1/1 commits from #108415.

/cc @cockroachdb/release


These upstream tests are flaky, so we ignore them.

Release justification: test only change
informs #108414
fixes #108044
fixes #108504
Release note: None

These upstream tests are flaky, so we ignore them.

Release note: None
@rafiss rafiss requested a review from a team August 11, 2023 03:39
@rafiss rafiss requested a review from a team as a code owner August 11, 2023 03:39
@rafiss rafiss requested review from rachitgsrivastava and DarrylWong and removed request for a team August 11, 2023 03:39
@blathers-crl
Copy link

blathers-crl bot commented Aug 11, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss requested a review from andyyang890 August 11, 2023 16:57
@rafiss rafiss merged commit 7257fab into cockroachdb:release-23.1 Aug 11, 2023
@rafiss rafiss deleted the backport23.1-108415 branch August 11, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants