Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: remove rangeTs clearrange variants #108487

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Aug 9, 2023

In clusters with finalized cluster versions ≥23.1, range tombstones are always enabled and the cluster setting has no effect. Remove the variations of the clearrange test, and we'll effectively always test with MVCC range tombstones.

Epic: none
Informs #97869.
Release note: none

In clusters with finalized cluster versions ≥23.1, range tombstones are always
enabled and the cluster setting has no effect. Remove the variations of the
clearrange test, and we'll effectively always test with MVCC range tombstones.

Epic: none
Informs cockroachdb#97869.
Release note: none
@jbowens jbowens requested review from erikgrinaker and a team August 9, 2023 21:59
@jbowens jbowens requested a review from a team as a code owner August 9, 2023 21:59
@jbowens jbowens requested review from rachitgsrivastava and DarrylWong and removed request for a team August 9, 2023 21:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Yey!

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong, @erikgrinaker, and @rachitgsrivastava)

@jbowens
Copy link
Collaborator Author

jbowens commented Aug 10, 2023

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 10, 2023

Build succeeded:

@craig craig bot merged commit 00f1d4e into cockroachdb:master Aug 10, 2023
@jbowens jbowens deleted the clearrange-rangetombstones branch August 10, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants