rfc: system.region_liveness #107966
Merged
rfc: system.region_liveness #107966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fqazi
requested changes
Aug 1, 2023
| within 15 seconds, `unavailalbe_at` is set to start the process of fencing out | ||
| the region. | ||
|
|
||
| 15 seconds is chosen because it gives enough time for leases to transfer in the |
There was a problem hiding this comment.
Is there any setting this number is based on?
There was a problem hiding this comment.
I think the value we care about here is COCKROACH_RANGE_LEASE_DURATION.
Line 192 in 126274a
But the sql server's may not have the kv server's configuration for that value.
|
Just my initial pass, I'll take another deeper look tomorrow |
chrisseto
reviewed
Aug 2, 2023
Create draft RFC for the `system.region_liveness` table. Informs: CC-24173 Release note: none
jeffswenson
force-pushed
the
jeffswenson-region-liveness
branch
from
263a6ab to
4068ff2
Compare
|
TYFT the reviews 😄 I replied to all of your comments and adjusted the RFC based on your feedback. |
fqazi
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @chrisseto and @jeffswenson)
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create draft RFC for the
system.region_livenesstable.Informs: CC-24173
Release note: none