Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowinfra: clean up flow stats propagation in row-based flows #106546

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Jul 10, 2023

Previously, we would attach FlowStats (like max memory usage) to the "stream component" stats object. I don't really understand why that was the case, probably it was due to misunderstanding how tracing works (in particular, the TODOs that are now removed mentioned "flow level span", but we don't need to attach the metadata to a particular tracing span).

This simplifies the code a bit but also simplifies the work on adding region information to ComponentID object.

Epic: None

Release note: None

Previously, we would attach `FlowStats` (like max memory usage) to the
"stream component" stats object. I don't really understand why that was
the case, probably it was due to misunderstanding how tracing works (in
particular, the TODOs that are now removed mentioned "flow level span",
but we don't need to attach the metadata to a particular tracing span).

This simplifies the code a bit but also simplifies the work on adding
region information to `ComponentID` object.

Release note: None
@yuzefovich yuzefovich requested review from j82w and a team July 10, 2023 20:11
@yuzefovich yuzefovich requested a review from a team as a code owner July 10, 2023 20:11
@yuzefovich yuzefovich requested a review from rytaft July 10, 2023 20:11
@blathers-crl
Copy link

blathers-crl bot commented Jul 10, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @j82w and @rytaft)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 10, 2023

Build succeeded:

@craig craig bot merged commit 33d9616 into cockroachdb:master Jul 10, 2023
@yuzefovich yuzefovich deleted the row-flow branch July 10, 2023 23:42
@yuzefovich
Copy link
Member Author

blathers backport 23.1

@blathers-crl
Copy link

blathers-crl bot commented Jul 11, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-106546 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/106597/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants