Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: schemachanger,scbuild: fix assertion bug #106286

Merged
merged 1 commit into from
Jul 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,6 @@ Schema change plan for DROP DATABASE ‹multi_region_test_db› CASCADE;
│ │ ├── PUBLIC → DROPPED Database:{DescID: 104}
│ │ ├── PUBLIC → ABSENT DatabaseRoleSetting:{DescID: 104, Name: __placeholder_role_name__}
│ │ ├── PUBLIC → ABSENT DatabaseRegionConfig:{DescID: 104, ReferencedDescID: 106}
│ │ ├── PUBLIC → ABSENT Namespace:{DescID: 105, Name: public, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Owner:{DescID: 105}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: admin}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: public}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: root}
│ │ ├── PUBLIC → DROPPED Schema:{DescID: 105}
│ │ ├── PUBLIC → ABSENT SchemaParent:{DescID: 105, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Namespace:{DescID: 106, Name: crdb_internal_region, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Owner:{DescID: 106}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 106, Name: admin}
Expand All @@ -36,6 +29,13 @@ Schema change plan for DROP DATABASE ‹multi_region_test_db› CASCADE;
│ │ ├── PUBLIC → ABSENT EnumTypeValue:{DescID: 106, Name: us-east2}
│ │ ├── PUBLIC → ABSENT EnumTypeValue:{DescID: 106, Name: us-east3}
│ │ ├── PUBLIC → ABSENT SchemaChild:{DescID: 106, ReferencedDescID: 105}
│ │ ├── PUBLIC → ABSENT Namespace:{DescID: 105, Name: public, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Owner:{DescID: 105}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: admin}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: public}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: root}
│ │ ├── PUBLIC → DROPPED Schema:{DescID: 105}
│ │ ├── PUBLIC → ABSENT SchemaParent:{DescID: 105, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Namespace:{DescID: 107, Name: _crdb_internal_region, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Owner:{DescID: 107}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 107, Name: admin}
Expand Down Expand Up @@ -84,12 +84,12 @@ Schema change plan for DROP DATABASE ‹multi_region_test_db› CASCADE;
│ ├── SetColumnName {"ColumnID":4294967294,"Name":"crdb_internal_co...","TableID":108}
│ ├── MakePublicPrimaryIndexWriteOnly {"IndexID":1,"TableID":108}
│ ├── SetIndexName {"IndexID":1,"Name":"crdb_internal_in...","TableID":108}
│ ├── MarkDescriptorAsDropped {"DescriptorID":105}
│ ├── RemoveSchemaParent {"Parent":{"ParentDatabaseID":104,"SchemaID":105}}
│ ├── NotImplementedForPublicObjects {"DescID":106,"ElementType":"scpb.Owner"}
│ ├── RemoveUserPrivileges {"DescriptorID":106,"User":"admin"}
│ ├── RemoveUserPrivileges {"DescriptorID":106,"User":"public"}
│ ├── RemoveUserPrivileges {"DescriptorID":106,"User":"root"}
│ ├── MarkDescriptorAsDropped {"DescriptorID":105}
│ ├── RemoveSchemaParent {"Parent":{"ParentDatabaseID":104,"SchemaID":105}}
│ ├── NotImplementedForPublicObjects {"DescID":107,"ElementType":"scpb.Owner"}
│ ├── RemoveUserPrivileges {"DescriptorID":107,"User":"admin"}
│ ├── RemoveUserPrivileges {"DescriptorID":107,"User":"public"}
Expand All @@ -102,12 +102,12 @@ Schema change plan for DROP DATABASE ‹multi_region_test_db› CASCADE;
│ ├── MakeWriteOnlyColumnDeleteOnly {"ColumnID":4294967295,"TableID":108}
│ ├── MakeWriteOnlyColumnDeleteOnly {"ColumnID":4294967294,"TableID":108}
│ ├── MarkDescriptorAsDropped {"DescriptorID":104}
│ ├── DrainDescriptorName {"Namespace":{"DatabaseID":104,"DescriptorID":106,"Name":"crdb_internal_re...","SchemaID":105}}
│ ├── DrainDescriptorName {"Namespace":{"DatabaseID":104,"DescriptorID":105,"Name":"public"}}
│ ├── NotImplementedForPublicObjects {"DescID":105,"ElementType":"scpb.Owner"}
│ ├── RemoveUserPrivileges {"DescriptorID":105,"User":"admin"}
│ ├── RemoveUserPrivileges {"DescriptorID":105,"User":"public"}
│ ├── RemoveUserPrivileges {"DescriptorID":105,"User":"root"}
│ ├── DrainDescriptorName {"Namespace":{"DatabaseID":104,"DescriptorID":106,"Name":"crdb_internal_re...","SchemaID":105}}
│ ├── DrainDescriptorName {"Namespace":{"DatabaseID":104,"DescriptorID":107,"Name":"_crdb_internal_r...","SchemaID":105}}
│ ├── DrainDescriptorName {"Namespace":{"DatabaseID":104,"DescriptorID":108,"Name":"table_regional_b...","SchemaID":105}}
│ ├── MakeWriteOnlyColumnDeleteOnly {"ColumnID":1,"TableID":108}
Expand All @@ -133,13 +133,6 @@ Schema change plan for DROP DATABASE ‹multi_region_test_db› CASCADE;
│ │ │ ├── DROPPED → PUBLIC Database:{DescID: 104}
│ │ │ ├── ABSENT → PUBLIC DatabaseRoleSetting:{DescID: 104, Name: __placeholder_role_name__}
│ │ │ ├── ABSENT → PUBLIC DatabaseRegionConfig:{DescID: 104, ReferencedDescID: 106}
│ │ │ ├── ABSENT → PUBLIC Namespace:{DescID: 105, Name: public, ReferencedDescID: 104}
│ │ │ ├── ABSENT → PUBLIC Owner:{DescID: 105}
│ │ │ ├── ABSENT → PUBLIC UserPrivileges:{DescID: 105, Name: admin}
│ │ │ ├── ABSENT → PUBLIC UserPrivileges:{DescID: 105, Name: public}
│ │ │ ├── ABSENT → PUBLIC UserPrivileges:{DescID: 105, Name: root}
│ │ │ ├── DROPPED → PUBLIC Schema:{DescID: 105}
│ │ │ ├── ABSENT → PUBLIC SchemaParent:{DescID: 105, ReferencedDescID: 104}
│ │ │ ├── ABSENT → PUBLIC Namespace:{DescID: 106, Name: crdb_internal_region, ReferencedDescID: 104}
│ │ │ ├── ABSENT → PUBLIC Owner:{DescID: 106}
│ │ │ ├── ABSENT → PUBLIC UserPrivileges:{DescID: 106, Name: admin}
Expand All @@ -150,6 +143,13 @@ Schema change plan for DROP DATABASE ‹multi_region_test_db› CASCADE;
│ │ │ ├── ABSENT → PUBLIC EnumTypeValue:{DescID: 106, Name: us-east2}
│ │ │ ├── ABSENT → PUBLIC EnumTypeValue:{DescID: 106, Name: us-east3}
│ │ │ ├── ABSENT → PUBLIC SchemaChild:{DescID: 106, ReferencedDescID: 105}
│ │ │ ├── ABSENT → PUBLIC Namespace:{DescID: 105, Name: public, ReferencedDescID: 104}
│ │ │ ├── ABSENT → PUBLIC Owner:{DescID: 105}
│ │ │ ├── ABSENT → PUBLIC UserPrivileges:{DescID: 105, Name: admin}
│ │ │ ├── ABSENT → PUBLIC UserPrivileges:{DescID: 105, Name: public}
│ │ │ ├── ABSENT → PUBLIC UserPrivileges:{DescID: 105, Name: root}
│ │ │ ├── DROPPED → PUBLIC Schema:{DescID: 105}
│ │ │ ├── ABSENT → PUBLIC SchemaParent:{DescID: 105, ReferencedDescID: 104}
│ │ │ ├── ABSENT → PUBLIC Namespace:{DescID: 107, Name: _crdb_internal_region, ReferencedDescID: 104}
│ │ │ ├── ABSENT → PUBLIC Owner:{DescID: 107}
│ │ │ ├── ABSENT → PUBLIC UserPrivileges:{DescID: 107, Name: admin}
Expand Down Expand Up @@ -190,13 +190,6 @@ Schema change plan for DROP DATABASE ‹multi_region_test_db› CASCADE;
│ │ ├── PUBLIC → DROPPED Database:{DescID: 104}
│ │ ├── PUBLIC → ABSENT DatabaseRoleSetting:{DescID: 104, Name: __placeholder_role_name__}
│ │ ├── PUBLIC → ABSENT DatabaseRegionConfig:{DescID: 104, ReferencedDescID: 106}
│ │ ├── PUBLIC → ABSENT Namespace:{DescID: 105, Name: public, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Owner:{DescID: 105}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: admin}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: public}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: root}
│ │ ├── PUBLIC → DROPPED Schema:{DescID: 105}
│ │ ├── PUBLIC → ABSENT SchemaParent:{DescID: 105, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Namespace:{DescID: 106, Name: crdb_internal_region, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Owner:{DescID: 106}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 106, Name: admin}
Expand All @@ -207,6 +200,13 @@ Schema change plan for DROP DATABASE ‹multi_region_test_db› CASCADE;
│ │ ├── PUBLIC → ABSENT EnumTypeValue:{DescID: 106, Name: us-east2}
│ │ ├── PUBLIC → ABSENT EnumTypeValue:{DescID: 106, Name: us-east3}
│ │ ├── PUBLIC → ABSENT SchemaChild:{DescID: 106, ReferencedDescID: 105}
│ │ ├── PUBLIC → ABSENT Namespace:{DescID: 105, Name: public, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Owner:{DescID: 105}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: admin}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: public}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 105, Name: root}
│ │ ├── PUBLIC → DROPPED Schema:{DescID: 105}
│ │ ├── PUBLIC → ABSENT SchemaParent:{DescID: 105, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Namespace:{DescID: 107, Name: _crdb_internal_region, ReferencedDescID: 104}
│ │ ├── PUBLIC → ABSENT Owner:{DescID: 107}
│ │ ├── PUBLIC → ABSENT UserPrivileges:{DescID: 107, Name: admin}
Expand Down Expand Up @@ -255,12 +255,12 @@ Schema change plan for DROP DATABASE ‹multi_region_test_db› CASCADE;
│ ├── SetColumnName {"ColumnID":4294967294,"Name":"crdb_internal_co...","TableID":108}
│ ├── MakePublicPrimaryIndexWriteOnly {"IndexID":1,"TableID":108}
│ ├── SetIndexName {"IndexID":1,"Name":"crdb_internal_in...","TableID":108}
│ ├── MarkDescriptorAsDropped {"DescriptorID":105}
│ ├── RemoveSchemaParent {"Parent":{"ParentDatabaseID":104,"SchemaID":105}}
│ ├── NotImplementedForPublicObjects {"DescID":106,"ElementType":"scpb.Owner"}
│ ├── RemoveUserPrivileges {"DescriptorID":106,"User":"admin"}
│ ├── RemoveUserPrivileges {"DescriptorID":106,"User":"public"}
│ ├── RemoveUserPrivileges {"DescriptorID":106,"User":"root"}
│ ├── MarkDescriptorAsDropped {"DescriptorID":105}
│ ├── RemoveSchemaParent {"Parent":{"ParentDatabaseID":104,"SchemaID":105}}
│ ├── NotImplementedForPublicObjects {"DescID":107,"ElementType":"scpb.Owner"}
│ ├── RemoveUserPrivileges {"DescriptorID":107,"User":"admin"}
│ ├── RemoveUserPrivileges {"DescriptorID":107,"User":"public"}
Expand All @@ -274,12 +274,12 @@ Schema change plan for DROP DATABASE ‹multi_region_test_db› CASCADE;
│ ├── MakeWriteOnlyColumnDeleteOnly {"ColumnID":4294967294,"TableID":108}
│ ├── MarkDescriptorAsDropped {"DescriptorID":104}
│ ├── RemoveDatabaseRoleSettings {"DatabaseID":104}
│ ├── DrainDescriptorName {"Namespace":{"DatabaseID":104,"DescriptorID":106,"Name":"crdb_internal_re...","SchemaID":105}}
│ ├── DrainDescriptorName {"Namespace":{"DatabaseID":104,"DescriptorID":105,"Name":"public"}}
│ ├── NotImplementedForPublicObjects {"DescID":105,"ElementType":"scpb.Owner"}
│ ├── RemoveUserPrivileges {"DescriptorID":105,"User":"admin"}
│ ├── RemoveUserPrivileges {"DescriptorID":105,"User":"public"}
│ ├── RemoveUserPrivileges {"DescriptorID":105,"User":"root"}
│ ├── DrainDescriptorName {"Namespace":{"DatabaseID":104,"DescriptorID":106,"Name":"crdb_internal_re...","SchemaID":105}}
│ ├── DrainDescriptorName {"Namespace":{"DatabaseID":104,"DescriptorID":107,"Name":"_crdb_internal_r...","SchemaID":105}}
│ ├── DrainDescriptorName {"Namespace":{"DatabaseID":104,"DescriptorID":108,"Name":"table_regional_b...","SchemaID":105}}
│ ├── MakeWriteOnlyColumnDeleteOnly {"ColumnID":1,"TableID":108}
Expand All @@ -305,17 +305,17 @@ Schema change plan for DROP DATABASE ‹multi_region_test_db› CASCADE;
├── 8 elements transitioning toward ABSENT
│ ├── DROPPED → ABSENT Database:{DescID: 104}
│ ├── PUBLIC → ABSENT DatabaseData:{DescID: 104}
│ ├── DROPPED → ABSENT Schema:{DescID: 105}
│ ├── DROPPED → ABSENT EnumType:{DescID: 106}
│ ├── DROPPED → ABSENT Schema:{DescID: 105}
│ ├── DROPPED → ABSENT AliasType:{DescID: 107, ReferencedTypeIDs: [106 107]}
│ ├── DROPPED → ABSENT Table:{DescID: 108}
│ ├── PUBLIC → ABSENT IndexData:{DescID: 108, IndexID: 1}
│ └── PUBLIC → ABSENT TableData:{DescID: 108, ReferencedDescID: 104}
└── 13 Mutation operations
├── DeleteDescriptor {"DescriptorID":104}
├── CreateGCJobForDatabase {"DatabaseID":104}
├── DeleteDescriptor {"DescriptorID":105}
├── DeleteDescriptor {"DescriptorID":106}
├── DeleteDescriptor {"DescriptorID":105}
├── DeleteDescriptor {"DescriptorID":107}
├── CreateGCJobForTable {"DatabaseID":104,"TableID":108}
├── CreateGCJobForIndex {"IndexID":1,"TableID":108}
Expand Down
Loading