[dnm] repro for #106108 #106254
Closed
[dnm] repro for #106108 #106254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
`andrei-jepsen` is very low on quota, and `cockroach-ephemeral` is no longer used by the nightlies but is well-quotaed, so we should use it instead. Remove an old tripwire that tried to prevent folks from using `cockroach-ephemeral`. Epic: None Release note: None
tbg
force-pushed
the
repro-failover-106108
branch
from
d332a2f to
4fbf12e
Compare
tbg
force-pushed
the
repro-failover-106108
branch
from
4fbf12e to
ada8fc8
Compare
tbg
commented
Jul 21, 2023
| @@ -37,6 +44,45 @@ func (m *Mutex) AssertHeld() { | |||
| // An RWMutex is a reader/writer mutual exclusion lock. | |||
| type RWMutex struct { | |||
| sync.RWMutex | |||
| pcs []uintptr | |||
| watching *time.Timer // from mtime.AfterFunc | |||
There was a problem hiding this comment.
anchor comment that I'll reference from elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #106108