Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: kvserver: don't report unreachable followers when quiesced #106251

Merged

Conversation

erikgrinaker
Copy link
Contributor

Backport 1/1 commits from #104212.

/cc @cockroachdb/release


Previously, Replica.tick() could mark a Raft follower as unreachable even if the replica was quiesced, transitioning it to StateProbe. This in turn can prevent lease transfers, which require the target to be up-to-date. However, with the range quiesced, the follower wouldn't transition back to healthy until the leader unquiesced for some reason.

We normally don't quiesce with a follower that isn't caught up, and applying internal state transitions while the range is quiesced is problematic since it won't have a chance to react to those state transitions.

This patch instead defers marking the follower as unreachable until the next tick, whenever the range unquiesces, such that the leader can detect the follower's recovery. Since ranges aren't allowed to quiesce when they have outstanding ready events or log entries, we're likely to detect unavailability and mark the follower as unavailable on the next tick before quiescing anyway.

Resolves #103828.

Epic: none
Release note: None

Previously, `Replica.tick()` could mark a Raft follower as unreachable
even if the replica was quiesced, transitioning it to `StateProbe`. This
in turn can prevent lease transfers, which require the target to be
up-to-date. However, with the range quiesced, the follower wouldn't
transition back to healthy until the leader unquiesced for some reason.

We normally don't quiesce with a follower that isn't caught up, and
applying internal state transitions while the range is quiesced is
problematic since it won't have a chance to react to those state
transitions.

This patch instead defers marking the follower as unreachable until the
next tick, whenever the range unquiesces, such that the leader can
detect the follower's recovery. Since ranges aren't allowed to quiesce
when they have outstanding ready events or log entries, we're likely to
detect unavailability and mark the follower as unavailable on the next
tick before quiescing anyway.

Epic: none
Release note: None
@erikgrinaker erikgrinaker requested a review from tbg July 6, 2023 09:34
@erikgrinaker erikgrinaker self-assigned this Jul 6, 2023
@erikgrinaker erikgrinaker requested a review from a team July 6, 2023 09:34
@blathers-crl
Copy link

blathers-crl bot commented Jul 6, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link

blathers-crl bot commented Jul 6, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker merged commit 2a703f3 into cockroachdb:release-23.1 Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants