Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: kvserver: propagate ReplicaUnavailableError from intent resolution #105869

Merged

Conversation

erikgrinaker
Copy link
Contributor

Backport 1/1 commits from #105816.

/cc @cockroachdb/release


If intent resolution attempted to access txn info on a different range, and hit a poisoned latch because that range had lost quorum, the returned error would incorrectly claim that the range with the intent was unavailable rather than the range that had lost quorum. This patch correctly propagates the ReplicaUnavailableError from the other range.

Resolves #105798.
Resolves #102936.
Epic: none

Release note: None

@erikgrinaker erikgrinaker requested review from pav-kv and tbg June 30, 2023 07:36
@erikgrinaker erikgrinaker self-assigned this Jun 30, 2023
@erikgrinaker erikgrinaker requested a review from a team as a code owner June 30, 2023 07:36
@blathers-crl
Copy link

blathers-crl bot commented Jun 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker requested a review from a team June 30, 2023 07:37
If intent resolution attempted to access txn info on a different range,
and hit a poisoned latch because that range had lost quorum, the
returned error would incorrectly claim that the range with the intent
was unavailable rather than the range that had lost quorum. This patch
correctly propagates the `ReplicaUnavailableError` from the other range.

Epic: none
Release note: None
@erikgrinaker erikgrinaker force-pushed the backport22.2-105816 branch from 756ba62 to 9e8007f Compare June 30, 2023 12:03
@erikgrinaker erikgrinaker merged commit ed99e65 into cockroachdb:release-22.2 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants