Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: expose env var to configure raft entry cache size #105799

Merged

Conversation

nvanbenschoten
Copy link
Member

Informs #98666.

This commit introduces a new COCKROACH_RAFT_ENTRY_CACHE_SIZE which can be used to configure the size of the raft entry cache. The default value is 16 MiB.

Release note: None

Informs cockroachdb#98666.

This commit introduces a new `COCKROACH_RAFT_ENTRY_CACHE_SIZE` which can
be used to configure the size of the raft entry cache. The default value
is 16 MiB.

Release note: None
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner June 29, 2023 06:37
@blathers-crl
Copy link

blathers-crl bot commented Jun 29, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker
Copy link
Contributor

Worth a backport?

@nvanbenschoten nvanbenschoten added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Jun 29, 2023
@nvanbenschoten
Copy link
Member Author

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Jun 29, 2023

Build succeeded:

@craig craig bot merged commit 2b66f95 into cockroachdb:master Jun 29, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jun 29, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from c309edc to blathers/backport-release-22.2-105799: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


error creating merge commit from c309edc to blathers/backport-release-23.1-105799: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

nvanbenschoten added a commit to nvanbenschoten/cockroach that referenced this pull request Jul 5, 2023
This commit cleans up the order of the raft environment variables to ensure that
raft scheduler related variables are grouped together. They were unintentionally
split by cockroachdb#105799.

Epic: None
Release note: None
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/raftEntryCacheSize branch July 17, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants