kvserver: improve server-side trace print on ctx cancellation #105703
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed in passing. When a replica circuit breaker trips, the error will typically wrap `context.Canceled` but this will have nothing to do with the client's `ctx` (and the logs will be spammed). If we try to be sensitive to client ctx cancellation, we ought to look at the client's ctx. Epic: none Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
adityamaru
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Thanks for doing this @erikgrinaker flagged this last week but I hadn't got around to sending the patch - #105378. Should we also not log if the sp.GetConfiguredRecording() returns an empty recording as noted in that issue?
That seems sensible, but I'd rather not grow this drive-by in scope. How about we leave the issue open to track that part? bors r=adityamaru |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in passing. When a replica circuit breaker trips, the error will
typically wrap
context.Canceledbut this will have nothing to do with theclient's
ctx(and the logs will be spammed). If we try to be sensitive toclient ctx cancellation, we ought to look at the client's ctx.
Epic: none
Release note: None