kvserver: fix and re-enable slow lease application logging #105519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgrinaker
added
the
backport-23.1.x
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
tbg
approved these changes
Jun 26, 2023
pkg/kv/kvserver/replica_proposal.go
Outdated
| if leaseChangingHands && iAmTheLeaseHolder { | ||
| // Log acquisition of meta and liveness range leases. These are critical to | ||
| // cluster health, so it's useful to know their location over time. | ||
| if r.descRLocked().StartKey.Less(roachpb.RKey(keys.NodeLivenessKeyMax)) { |
There was a problem hiding this comment.
From the looks of it this could be moved into maybeLogSlowLeaseApplyWarning with system bool flag, but it's fine as is too.
There was a problem hiding this comment.
This isn't slow application though, we log every time the lease is acquired regardless of how slowly it's applied. But I can restructure the entire method to be about lease application logging.
Epic: none Release note: None
erikgrinaker
force-pushed
the
fix-slow-lease-logging
branch
from
8d6172b to
14b992c
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #97209.
Epic: none
Release note: None