sql: ensure sub-plans of CREATE TABLE AS and CREATE VIEW are always closed #10527
Conversation
|
Reviewed 3 of 3 files at r1. pkg/sql/create.go, line 634 at r1 (raw file):
Is removing this logic related? Why is it not needed anymore? It might deserve a callout in the commit message (or a separate commit if it is indeed unrelated) Comments from Reviewable |
Prior to this patch, the code for CREATE AS would give the column signature of the source table as "desired type" for the internal insertNode it uses to populate the new table. This is conceptually problematic, as the source table is the source to the insertNode, and not its consumer. It is also entirely ineffectual in this case, because the internal insertNode used by CREATE TABLE AS does not use a RETURNING clause and thus cannot used the "desired types" provided by its context. This patch removes this connection.
|
TFYR! Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending. pkg/sql/create.go, line 634 at r1 (raw file):
|
Addresses an issue found while investigating #10466:
#10466 (comment)
This change is