Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql: use datum alloc for crdb_internal stmt stats rows #105204

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 20, 2023

Backport 1/1 commits from #105093 on behalf of @dt.

/cc @cockroachdb/release


Happened to observe a cluster running a customer test suite which included a query that inspected stmt stats often, causing the CRDB node to spend a considerable amount of CPU time in production of the stmt stats vtable, in particular allocating (and then GC'ing) individual datums, especially given how wide this table has become with the addition of storage stats.

This change uses a datum allocator to produce those rows to reduce the number of separate allocations from the runtime.

Release note: none.
Epic: none.


Release justification: low risk performance improvement

@blathers-crl blathers-crl bot requested a review from a team as a code owner June 20, 2023 16:46
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-105093 branch from 4749b68 to 6060a1e Compare June 20, 2023 16:46
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label Jun 20, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-105093 branch from d178b29 to b2e9d37 Compare June 20, 2023 16:46
@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label Jun 20, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from ericharmeling and rafiss June 20, 2023 16:46
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 20, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss requested a review from dt June 20, 2023 16:46
Happened to observe a cluster running a customer test suite which included a query that
inspected stmt stats often, causing the CRDB node to spend a considerable amount of CPU
time in production of the stmt stats vtable, in particular allocating (and then GC'ing)
individual datums. This change uses a datum allocator to produce those rows to reduce the
number of separate allocations from the runtime.

Release note: none.
Epic: none.
@rafiss rafiss force-pushed the blathers/backport-release-23.1-105093 branch from b2e9d37 to dfc2388 Compare June 21, 2023 14:57
@rafiss rafiss merged commit 3ac3a05 into release-23.1 Jun 21, 2023
@rafiss rafiss deleted the blathers/backport-release-23.1-105093 branch June 21, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants