Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: kvcoord: Release catchup reservation before re-acquire attempt #105186

Merged
merged 1 commit into from
Jun 20, 2023
Merged

release-23.1: kvcoord: Release catchup reservation before re-acquire attempt #105186

merged 1 commit into from
Jun 20, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 20, 2023 •
edited by miretskiy
Loading

Backport 1/1 commits from #105083 on behalf of @miretskiy.

/cc @cockroachdb/release

Release catchup scan reservation prior to attemt to re-acquire it. Failure to do so could result in a stuck mux rangefeed when enough ranges encounter an error, such as range split, prior to receiving the first checkpoint event, that would cause additional attempts to acquire catchup scan quota.

Fixes #105058

Release note (bug fix): Fix a bug in mux rangefeed implementation that may cause mux rangefeed to become stuck if enough ranges encounter certain error concurrently.

Release justification: bug fix

kvcoord: Release catchup reservation before re-acquire attempt
7031b98 
Release catchup scan reservation prior to attemt to re-acquire
it.  Failure to do so could result in a stuck mux rangefeed when enough
ranges encounter an error at the same time (which can happen if
e.g. a node gets restarted).

Fixes #105058

Release note (bug fix): Fix a bug in mux rangefeed implementation that
may cause mux rangefeed to become stuck if enough ranges enounter
certain error concurrently.
@blathers-crl blathers-crl bot requested a review from a team June 20, 2023 14:14
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-105083 branch from 6b30777 to 329cfe1 Compare June 20, 2023 14:14
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 20, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from aliher1911 June 20, 2023 14:14
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-105083 branch from 50e0927 to 7031b98 Compare June 20, 2023 14:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@miretskiy miretskiy merged commit 4749b68 into release-23.1 Jun 20, 2023
@miretskiy miretskiy deleted the blathers/backport-release-23.1-105083 branch June 20, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliher1911 aliher1911 aliher1911 approved these changes

Assignees

@miretskiy miretskiy

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @aliher1911 @miretskiy