Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: remove circleci badge #10513

Closed
wants to merge 1 commit into from
Closed

README.md: remove circleci badge #10513

wants to merge 1 commit into from

Conversation

andreimatei
Copy link
Contributor

@andreimatei andreimatei commented Nov 7, 2016 •
edited by rjnn
Loading

This change is Reviewable

@tamird
Copy link
Contributor

tamird commented Nov 7, 2016

LGTM

On Mon, Nov 7, 2016 at 2:34 PM, Andrei Matei [email protected]
wrote:

You can view, comment on, or merge this pull request online at:

#10513
Commit Summary

  • README.md: remove circleci badge

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#10513, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABdsPIGbrSFhF8TP7cAv_hyUxtvMuQaUks5q731EgaJpZM4Krnlw
.

tamird
tamird approved these changes Nov 7, 2016
View reviewed changes
README.md
@@ -1,7 +1,7 @@
![logo](docs/media/cockroach_db.png?raw=true "Cockroach Labs logo")


[![Circle CI](https://circleci.com/gh/cockroachdb/cockroach.svg?style=svg)](https://circleci.com/gh/cockroachdb/cockroach) [![GoDoc](https://godoc.org/github.com/cockroachdb/cockroach?status.svg)](https://godoc.org/github.com/cockroachdb/cockroach) ![Project Status](https://img.shields.io/badge/status-beta-yellow.svg) [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/cockroachdb/cockroach?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
[![GoDoc](https://godoc.org/github.com/cockroachdb/cockroach?status.svg)](https://godoc.org/github.com/cockroachdb/cockroach) ![Project Status](https://img.shields.io/badge/status-beta-yellow.svg) [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/cockroachdb/cockroach?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're here, can you add some newlinews? I don't believe they affect how this is rendered.

@jordanlewis
Copy link
Member

Wanna add a TeamCity badge? https://confluence.jetbrains.com/display/TCD10/REST+API#RESTAPI-BuildStatusIcon

@jordanlewis
Copy link
Member

You can use this link: https://teamcity.cockroachdb.com/guestAuth/app/rest/builds/buildType:(id:Cockroach_UnitTests)/statusIcon.svg

It looks like this: status

@dt dt mentioned this pull request Nov 23, 2016
Merged
dt added a commit to dt/cockroach that referenced this pull request Nov 23, 2016
@dt
README.md: replace CircleCI badge with TC
f776a4f 
Closes cockroachdb#10513.
@dt dt closed this in #11207 Nov 23, 2016
@tamird tamird deleted the andreimatei-readme branch February 22, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamird tamird tamird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreimatei @tamird @jordanlewis