Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: clarify kv.raft_log.disable_synchronization_unsafe #104888

Merged
merged 1 commit into from
Jun 14, 2023
Merged

kvserver: clarify kv.raft_log.disable_synchronization_unsafe #104888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/kv/kvserver/logstore/logstore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ import (
var disableSyncRaftLog = settings.RegisterBoolSetting(
settings.SystemOnly,
"kv.raft_log.disable_synchronization_unsafe",
"set to true to disable synchronization on Raft log writes to persistent storage. "+
"Setting to true risks data loss or data corruption on server crashes. "+
"disables synchronization of Raft log writes to persistent storage. "+
"Setting to true risks data loss or data corruption on process or OS crashes. "+
"This not only disables fsync, but also disables flushing writes to the OS buffer. "+
"The setting is meant for internal testing only and SHOULD NOT be used in production.",
envutil.EnvOrDefaultBool("COCKROACH_DISABLE_RAFT_LOG_SYNCHRONIZATION_UNSAFE", false),
)
Expand Down