Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades: deflake TestBackfillJobsInfoTable #104879

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

adityamaru
Copy link
Contributor

Previously, this test created jobs that could be adopted during test execution causing the number of payload/progress updates to be variable. With this change we create startable jobs so that they are not adopted and the number of payload/progress remain constant.

Fixes: #103046
Release note: None

Previously, this test created jobs that could be adopted
during test execution causing the number of payload/progress
updates to be variable. With this change we create startable
jobs so that they are not adopted and the number of payload/progress
remain constant.

Fixes: cockroachdb#103046
Release note: None
@adityamaru adityamaru requested a review from stevendanna June 14, 2023 14:21
@adityamaru adityamaru requested a review from a team as a code owner June 14, 2023 14:21
@adityamaru adityamaru added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Jun 14, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
Copy link
Contributor Author

bors r=stevendanna

@craig
Copy link
Contributor

craig bot commented Jun 14, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 14, 2023

Build succeeded:

@craig craig bot merged commit 3441110 into cockroachdb:master Jun 14, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jun 14, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from f523899 to blathers/backport-release-23.1-104879: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade/upgrades: TestBackfillJobsInfoTable failed
3 participants