diagnostics: Fixed a crashing bug when creating diagnostics report

[Xiang-Gu]

This commit fixed a bug where the node would sometimes crash when creating diagnostics report.

Fixes: #104172
Epic: None
Release note: None

[cockroach-teamcity]

This change is 

[rafiss]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Xiang-Gu)

---

pkg/server/diagnostics/reporter_test.go line 43 at r1 (raw file):

	}

	reflectwalk.Walk(foo, stringRedactor{})

nit: check the error here

[rafiss]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Xiang-Gu)

---

pkg/server/diagnostics/reporter.go line 323 at r1 (raw file):

}

func (r *Reporter) collectSchemaInfo(ctx context.Context) ([]descpb.TableDescriptor, error) {

nit: leave a comment here that describes that the schematelemetry is a better data source.

[Xiang-Gu]

TFTR!

bors r+

[craig]

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

[yuzefovich]

bors r+ single on

[craig]

Build failed:

• Bazel Essential CI (Cockroach)

[yuzefovich]

Seems like unrelated flake.

bors r+ single on

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from eb60c01 to blathers/backport-release-22.2-104543: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.

---

error creating merge commit from eb60c01 to blathers/backport-release-23.1-104543: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}