Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: rpc: use the loopback conn also for GRPCDialOptions #103775

Merged
merged 1 commit into from
May 23, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 23, 2023

Backport 1/1 commits from #103764 on behalf of @knz.

/cc @cockroachdb/release


Fixes #103762.
Fixes #99261.
Fixes #103692.

For context, rpc.GRPCDialOptions is used in two cases:

  • when connecting to other nodes as specified by the --join flag.
  • in the grpc-gateway code, to route incoming HTTP requests to the RPC subsystem.

The first one nearly always targets remotes nodes. The second one always targets the local node (it's a loopback connection).

Prior to this patch, the 2 callers to rpc.GRPCDialOptions would be served the regular "remote network conn" dial options unconditionally, including the backoff, only-once-dialer and other parameters suitable to connect to other nodes remotely.

While this choice is suitable for the --join logic, it's not suitable for the grpc-gateway loopback conn. In that case, we want to avoid all the network intelligence and especially avoid the only-once-dialer and circuit breaker.

This patch ensures that grpc-gateway receives the loopback parameters properly.

Release note (bug fix): A bug was fixed whereby under high CPU load,
HTTP requests to certain API endpoints (e.g. the health endpoint)
could start failing and then never succeed again until the node was
restarted. This bug had been introduced in v23.1.


Release justification: fixes major regression in 23.1

For context, `rpc.GRPCDialOptions` is used in two cases:

- when connecting to other nodes as specified by the `--join` flag.
- in the grpc-gateway code, to route incoming HTTP requests to the RPC
  subsystem.

The first one nearly always targets remotes nodes. The second one
always targets the local node (it's a loopback connection).

Prior to this patch, the 2 callers to `rpc.GRPCDialOptions` would be
served the regular "remote network conn" dial options unconditionally,
including the backoff, only-once-dialer and other parameters suitable
to connect to other nodes remotely.

While this choice is suitable for the `--join` logic, it's not
suitable for the grpc-gateway loopback conn. In that case, we want to
avoid all the network intelligence and especially avoid the
only-once-dialer and circuit breaker.

This patch ensures that grpc-gateway receives the loopback parameters properly.

Release note (bug fix): A bug was fixed whereby under high CPU load,
HTTP requests to certain API endpoints (e.g. the health endpoint)
could start failing and then never succeed again until the node was
restarted. This bug had been introduced in v23.1.
@blathers-crl blathers-crl bot requested review from a team as code owners May 23, 2023 13:20
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-103764 branch from db8fa2e to 7f849f7 Compare May 23, 2023 13:20
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 23, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-103764 branch from 4f45b58 to 4220702 Compare May 23, 2023 13:20
@blathers-crl blathers-crl bot requested a review from tbg May 23, 2023 13:20
@blathers-crl
Copy link
Author

blathers-crl bot commented May 23, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg removed their request for review May 23, 2023 13:24
@knz knz merged commit 6b592f8 into release-23.1 May 23, 2023
@knz knz deleted the blathers/backport-release-23.1-103764 branch May 23, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants