Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1.0: cli,server: static configuration profiles #101958

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 20, 2023

Backport 1/1 commits from #98466 on behalf of @knz.

/cc @cockroachdb/release


Epic: CRDB-23559
Informs #98431.
Fixes #94856.
(Based off #98459)
Supersedes #98380.

This change introduces a mechanism through which an operator can
select a "configuration profile" via the command-line flag
--config-profile or env var COCKROACH_CONFIG_PROFILE. The SQL
initialization defined by the profile is applied during server
start-up.

The profiles are (currently) hardcoded inside CockroachDB.

The following profiles are predefined:

  • default: no configuration.

  • multitenant+noapp: no pre-defined application tenant, but with a
    predefined application tenant template that is used whenever a new
    tenant is defined. This config profile is meant for use for C2C
    replication target clusters.

  • multitenant+app+sharedservice: shared-process multitenancy with
    pre-defined application tenant, based off the same configuration as
    multitenant+noapp.

Release note: None


Release justification: UX improvement for c2c customer preview

@blathers-crl blathers-crl bot requested review from a team as code owners April 20, 2023 21:56
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1.0-98466 branch from 06fea49 to 67de2e6 Compare April 20, 2023 21:56
@blathers-crl blathers-crl bot requested review from a team as code owners April 20, 2023 21:56
@blathers-crl blathers-crl bot requested a review from a team April 20, 2023 21:56
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 20, 2023 21:56
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label Apr 20, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label Apr 20, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1.0-98466 branch from 8c95d6b to b21a080 Compare April 20, 2023 21:56
@blathers-crl blathers-crl bot requested review from smg260 and renatolabs and removed request for a team April 20, 2023 21:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This change introduces a mechanism through which an operator can
select a "configuration profile" via the command-line flag
`--config-profile` or env var `COCKROACH_CONFIG_PROFILE`. The SQL
initialization defined by the profile is applied during server
start-up.

The profiles are (currently) hardcoded inside CockroachDB.

The following profiles are predefined:

- `default`: no configuration.

- `multitenant+noapp`: no pre-defined `application` tenant, but with a
  predefined application tenant template that is used whenever a new
  tenant is defined. This config profile is meant for use for C2C
  replication target clusters.

- `multitenant+app+sharedservice`: shared-process multitenancy with
  pre-defined `application` tenant, based off the same configuration as
  `multitenant+noapp`.

- `replication-source`: alias for `multitenant+app+sharedservice`
- `replication-target`: alias for `multitenant+noapp`

Release note: None
@knz knz force-pushed the blathers/backport-release-23.1.0-98466 branch from b21a080 to a582ebe Compare April 21, 2023 07:25
@knz knz merged commit 4a2222d into release-23.1.0 Apr 21, 2023
@knz knz deleted the blathers/backport-release-23.1.0-98466 branch April 21, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants