-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1.0: cli,server: static configuration profiles #101958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1.0-98466
branch
from
April 20, 2023 21:56
06fea49
to
67de2e6
Compare
blathers-crl
bot
added
the
blathers-backport
This is a backport that Blathers created automatically.
label
Apr 20, 2023
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1.0-98466
branch
from
April 20, 2023 21:56
8c95d6b
to
b21a080
Compare
blathers-crl
bot
requested review from
smg260 and
renatolabs
and removed request for
a team
April 20, 2023 21:56
knz
approved these changes
Apr 20, 2023
This change introduces a mechanism through which an operator can select a "configuration profile" via the command-line flag `--config-profile` or env var `COCKROACH_CONFIG_PROFILE`. The SQL initialization defined by the profile is applied during server start-up. The profiles are (currently) hardcoded inside CockroachDB. The following profiles are predefined: - `default`: no configuration. - `multitenant+noapp`: no pre-defined `application` tenant, but with a predefined application tenant template that is used whenever a new tenant is defined. This config profile is meant for use for C2C replication target clusters. - `multitenant+app+sharedservice`: shared-process multitenancy with pre-defined `application` tenant, based off the same configuration as `multitenant+noapp`. - `replication-source`: alias for `multitenant+app+sharedservice` - `replication-target`: alias for `multitenant+noapp` Release note: None
knz
force-pushed
the
blathers/backport-release-23.1.0-98466
branch
from
April 21, 2023 07:25
b21a080
to
a582ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #98466 on behalf of @knz.
/cc @cockroachdb/release
Epic: CRDB-23559
Informs #98431.
Fixes #94856.
(Based off #98459)
Supersedes #98380.
This change introduces a mechanism through which an operator can
select a "configuration profile" via the command-line flag
--config-profile
or env varCOCKROACH_CONFIG_PROFILE
. The SQLinitialization defined by the profile is applied during server
start-up.
The profiles are (currently) hardcoded inside CockroachDB.
The following profiles are predefined:
default
: no configuration.multitenant+noapp
: no pre-definedapplication
tenant, but with apredefined application tenant template that is used whenever a new
tenant is defined. This config profile is meant for use for C2C
replication target clusters.
multitenant+app+sharedservice
: shared-process multitenancy withpre-defined
application
tenant, based off the same configuration asmultitenant+noapp
.Release note: None
Release justification: UX improvement for c2c customer preview