Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyvisjob: mark the keyvis job as idle when it is not doing useful work #101750

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

zachlite
Copy link
Contributor

Resolves #101539
Epic: none
Release note: None

@zachlite zachlite requested a review from adityamaru April 18, 2023 14:54
@zachlite zachlite added backport-23.1.0 backport-23.1.x Flags PRs that need to be backported to 23.1 labels Apr 18, 2023
@zachlite
Copy link
Contributor Author

cc @tbg

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@adityamaru adityamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Should we backport this?

@blathers-crl
Copy link

blathers-crl bot commented Apr 18, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@zachlite
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 18, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyvisjob: key visualizer job should set MarkIdle to true
3 participants