Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: schemachange/mixed-versions: check version for JSON types #101638

Merged
merged 1 commit into from
Apr 20, 2023
Merged

roachtest: schemachange/mixed-versions: check version for JSON types #101638

merged 1 commit into from
Apr 20, 2023

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Apr 17, 2023 •
edited
Loading

Previously, the mixed version test could generate SQL not valid in a mixed version state with JSON types in indexes. To address this, this patch adds a version check for validating that these indexes are supported.

Fixes: #101274, #101409, #101514

Release note: None

@fqazi fqazi requested a review from a team April 17, 2023 13:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@fqazi fqazi marked this pull request as ready for review April 17, 2023 17:07
@fqazi fqazi requested a review from a team as a code owner April 17, 2023 17:07
@fqazi fqazi requested review from srosenberg and renatolabs and removed request for a team April 17, 2023 17:07
@renatolabs
Copy link
Contributor

Can you also make this commit fix #101409 and #101514 please?

@fqazi fqazi force-pushed the mixedSCWorkloadVersion branch from e3a3755 to 23aa512 Compare April 18, 2023 20:24
@fqazi
Copy link
Collaborator Author

fqazi commented Apr 18, 2023

Can you also make this commit fix #101409 and #101514 please?

Done @renatolabs

@renatolabs
Copy link
Contributor

Can you also make this commit fix #101409 and #101514 please?

Done @renatolabs

Sadly GitHub's syntax for closing multiple issues requires repeating the fixes or resolves keyword (source: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword).

@fqazi
Copy link
Collaborator Author

fqazi commented Apr 18, 2023

TFTR @chengxiong-ruan @renatolabs

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 18, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@craig
Copy link
Contributor

craig bot commented Apr 18, 2023

GitHub status checks took too long to complete, so bors is giving up. You can adjust bors configuration to have it wait longer if you like.

@fqazi
Copy link
Collaborator Author

fqazi commented Apr 19, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 19, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@fqazi
roachtest: schemachange/mixed-versions: check version for JSON types
3df16cb 
Previously, the mixed version test could generate SQL not
valid in a mixed version state with JSON types in indexes. To
address this, this patch adds a version check for validating
that these indexes are supported.

Fixes: cockroachdb#101274, cockroachdb#101409, cockroachdb#101514

Release note: None
@fqazi fqazi force-pushed the mixedSCWorkloadVersion branch from 23aa512 to 3df16cb Compare April 19, 2023 11:58
@fqazi
Copy link
Collaborator Author

fqazi commented Apr 20, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 20, 2023

Build succeeded:

@craig craig bot merged commit 0ffba81 into cockroachdb:master Apr 20, 2023
This was referenced Apr 20, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg is a code owner automatically assigned from cockroachdb/test-eng

@renatolabs renatolabs Awaiting requested review from renatolabs renatolabs is a code owner automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roachtest: schemachange/mixed-versions failed
4 participants
@fqazi @cockroach-teamcity @renatolabs @chengxiong-ruan