release-23.1: kvserver: use qps for hot ranges sorting #100211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
We introduced CPU balancing by default in #97424. This had the side effect of changing the hot ranges api to return the hottest replicas by CPU, rather than QPS. This patch updates the replica rankings struct to support tracking both by CPU and QPS simultaneously. The hot ranges API collects the top k by QPS and the store rebalancer collects depending on the setting of `kv.allocator.load_based_rebalancing.objective`, which is by default `cpu`. Resolves: #99605 Release note (bug fix): The hot ranges UI page would show hot ranges by CPU and not QPS, depending on the value of `kv.allocator.load_based_rebalancing.objective` (default `cpu`). Now the UI page will always collect based on QPS.
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-99716
branch
2 times, most recently
from
816faba to
24d06ef
Compare
blathers-crl
bot
added
blathers-backport
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
|
This change is |
nvanbenschoten
approved these changes
Apr 3, 2023
| @@ -138,23 +143,33 @@ func (rr *ReplicaRankings) TopLoad() []CandidateReplica { | |||
| // prevents concurrent loaders of data from messing with each other -- the last | |||
| // `update`d accumulator will win. | |||
| type RRAccumulator struct { | |||
| dim rrPriorityQueue | |||
| dims map[load.Dimension]*rrPriorityQueue | |||
There was a problem hiding this comment.
The map here feels heavyweight when we could use a slice like we do in load.Vector. It doesn't need to be changed here, but consider replacing on master.
There was a problem hiding this comment.
Agree - I will change on master.
There was a problem hiding this comment.
Perhaps you could try out some generics here with a structure like type load.Map[T any] [nDimensions]T.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #99716 on behalf of @kvoli.
/cc @cockroachdb/release
We introduced CPU balancing by default in #97424. This had the side effect of changing the hot ranges api to return the hottest replicas by CPU, rather than QPS.
This patch updates the replica rankings struct to support tracking both by CPU and QPS simultaneously. The hot ranges API collects the top k by QPS and the store rebalancer collects depending on the setting of
kv.allocator.load_based_rebalancing.objective, which is by defaultcpu.Resolves: #99605
Release justification: Fixes hot ranges sorting to always be by QPS for backwards compatibility.