Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanconfigs: enable span config bounds by default #100120

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

arulajmani
Copy link
Collaborator

@arulajmani arulajmani commented Mar 30, 2023

We only clamp spanconfigs if the spanconfig.bounds.enabled cluster setting dictates as such. For 23.1, it's default off, but going forward we want it to be default on. Let's also make this cluster setting public.

Epic: none
Epic: CRDB-16706

Release note: None

@arulajmani arulajmani requested a review from ajwerner March 30, 2023 14:06
@arulajmani arulajmani requested a review from a team as a code owner March 30, 2023 14:06
@cockroach-teamcity
Copy link
Member

This change is Reviewable

We only clamp spanconfigs if the `spanconfig.bounds.enabled` cluster
setting dictates as such. For 23.1, it's default off, but going forward
we want it to be default on. Let's also make this cluster setting
public.

Epic: none
Epic: CRDB-8035

Release note: None
@arulajmani arulajmani force-pushed the scfg-bounds-default-on branch from cf8da0b to 0d4c5bc Compare March 30, 2023 14:06
@arulajmani arulajmani changed the title spanconfigs: enable spanconfigbounds default on spanconfigs: enable span config bounds by default Mar 30, 2023
@arulajmani
Copy link
Collaborator Author

TFTR!

bors r=knz

@craig
Copy link
Contributor

craig bot commented Mar 30, 2023

Build succeeded:

@craig craig bot merged commit b60a8cd into cockroachdb:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants