Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: server: fix DataDistribution server error when creating a tenant #100010

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 30, 2023

Backport 1/1 commits from #99142 on behalf of @zachlite.

/cc @cockroachdb/release


This is a stop-gap commit that enables the DataDistribution endpoint to handle the parts of the key space belonging to secondary tenants without error.

Despite no error, the result returned for secondary tenants is not correct. The DataDistribution endpoint was written before #79700, and therefore doesn't know that multiple tables can exist within a range.

Additionally, the results for the system tenant will be incorrect soon because #81008 is in progress.
Improvements are tracked by #97942

Fixes: #97993
Release note: None


Release justification: Low risk bug fix

This is a stop-gap commit that enables the DataDistribution endpoint
to handle the parts of the key space belonging to secondary tenants
without error.

Despite no error, the result returned for secondary tenants is not correct.
The DataDistribution endpoint was written before #79700, and therefore
doesn't know that multiple tables can exist within a range.

Additionally, the results for the system tenant will be incorrect soon
because #81008 is in progress.

Fixes: #97993
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 30, 2023 03:25
@blathers-crl blathers-crl bot requested a review from a team March 30, 2023 03:25
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99142 branch 2 times, most recently from 4580e5b to 202fd0a Compare March 30, 2023 03:25
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@zachlite zachlite merged commit fd9eb79 into release-23.1 Mar 30, 2023
@zachlite zachlite deleted the blathers/backport-release-23.1-99142 branch March 30, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants