-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccl/multiregionccl: TestMultiRegionDataDriven failed #99563
Comments
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-23.1 @ 186218edb86b5974501b2976cfd0704d4d6d1beb:
Parameters: Same failure on other branches
|
This is the 23.1 branch manifestation of #98020. Assigning to @matthewtodd to close when the fix is back ported. |
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-23.1 @ a34af06d8e7230e4052db80d55da21a06013f81b:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-23.1 @ b15bd6f312c63f45d6246044238ef4645bfcd3a3:
Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-23.1 @ 84905b8396e7cd7ef999b264faaafe13110d631a:
Parameters: Same failure on other branches
|
I've just sent #102192 to address these flakes. |
102192: sqlstats: only include local region in statement_statistics r=j82w a=matthewtodd Part of #89949. Addresses #98020. Addresses #99563. Related to cockroachdb/roachperf#129. Related to #102170. Previously, we attempted to record all the regions hit in a single statement execution in the sqlstats tables, leaning on the sqlAddressResolver to map traced nodeIDs to localities at execution time. While the sqlAddressResolver is generally non-blocking, the introduction of this code did cause some of the multiregion "this query shouldn't span regions" tests to start [flaking][] and it's more recently been [implicated][] in a 2.5% performance regression. Given that the probabilistic nature of the tracing meant that we generally weren't capturing all the relevant nodeIDs anyway, it seems like the most prudent thing to do here is take a step back and regroup. In the short term, let's stop even trying to gather all these regions. In the medium/long term, let's see if we can find a better approach. [flaking]: #98020 [implicated]: https://github.com/cockroachdb/roachperf/pull/129 Release note: None Co-authored-by: Matthew Todd <[email protected]>
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-23.1 @ e84e2cabef32a59d88041132f059a6768dfe56bb:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-23.1 @ 870f9f667dd34bd0c926d38c08193db2672d78ff:
Parameters: Same failure on other branches
|
closing in favor of #98020 |
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-23.1 @ f351747ed97862fc037717cadec23f18073fb6be:
Parameters:
TAGS=bazel,gss
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
This test on roachdash | Improve this report!
Jira issue: CRDB-25936
The text was updated successfully, but these errors were encountered: