storage: TestPebbleMetricEventListener failed #96635
Assignees
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
T-storage
Storage Team
Milestone
Comments
cockroach-teamcity
added
branch-master
craig bot
pushed a commit
that referenced
this issue
Feb 6, 2023
95245: sem/tree: avoid heap allocs during pretty-printing r=chengxiong-ruan,rafiss a=knz
Everywhere applicable, change
```go
for i, xxx := range yyy {
ctx.FormatNode(&xxx)
}
```
to:
```go
for i := range yyy {
ctx.FormatNode(&yyy[i])
}
```
Epic: None
96476: sql: validate function volatility r=chengxiong-ruan a=chengxiong-ruan
This commits adds a simple udf volatility check by utilizing
the volatilities collected by the optbuilder when building a
statement. Errors are throw if any statement is not as strict
as the target volatility. Stable function folding is turned off
when building statements in CREATE FUNCTION to catch stable
function's volatility.
Release note (sql change): Previously, UDFs can be created with
any volatility no matter if the function body statements contain
any expression which would violate the target volatility. For
example, an immutable function might use `random()` in it. This
change added validations to guarantee that all statements in the
function body should be as strict as the expected UDF volatility.
Informs: #87699
96515: ui: fix time scale selection r=maryliag a=maryliag
When making a call to retrieve the list of fingerprints per index, it was suppose to use the round dates from the time picker, otherwise it wouldn't get the rounded hour that has the aggregated timestamp.
Epic: None
Release note: None
96651: storage: fix TestPebbleMetricEventListener r=itsbilal a=jbowens
In #96021 handling of disk slow events was made asynchronous. This introduced a race during Close where the goroutine logging could still be inflight.
Fix #96635.
Epic: None
Release note: None
Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Chengxiong Ruan <[email protected]>
Co-authored-by: maryliag <[email protected]>
Co-authored-by: Jackson Owens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
storage.TestPebbleMetricEventListener failed with artifacts on master @ 622956b9317831449010ba69207dbd112d48f9ab:
Parameters:
TAGS=bazel,gss,deadlockHelp
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-24254
The text was updated successfully, but these errors were encountered: