Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: TestDockerCLI/test_demo_networking.tcl flaked on master #96450

Closed
msbutler opened this issue Feb 2, 2023 · 4 comments
Closed

cli: TestDockerCLI/test_demo_networking.tcl flaked on master #96450

msbutler opened this issue Feb 2, 2023 · 4 comments
Assignees
@rafiss
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). skipped-test T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@msbutler
Copy link
Collaborator

msbutler commented Feb 2, 2023 •
edited by cockroach-jira-scripts
Loading

See failure in CI here https://teamcity.cockroachdb.com/viewLog.html?buildId=8559246&buildTypeId=Cockroach_BazelEssentialCi

Jira issue: CRDB-24130
@msbutler msbutler added C-test-failure Broken test (automatically or manually discovered). T-server-and-security DB Server & Security labels Feb 2, 2023
@msbutler
Copy link
Collaborator Author

msbutler commented Feb 2, 2023

i've hit this several times. Opening a PR to skip.

msbutler added a commit to msbutler/cockroach that referenced this issue Feb 2, 2023
@msbutler
cli: disable test_demo_networking
26f4427 
Informs cockroachdb#96450

Epic: None
@msbutler msbutler mentioned this issue Feb 2, 2023
Merged
@adityamaru
Copy link
Contributor

I'm not sure who triages server-related tickets these days, so pinging @knz just in case.

craig bot pushed a commit that referenced this issue Feb 2, 2023
@msbutler
Merge #96456
68078e6 
96456: cli: skip TestDockerCLI/test_demo_networking r=srosenberg a=msbutler

Informs #96450

Epic: None

Co-authored-by: Michael Butler <[email protected]>
@rafiss rafiss mentioned this issue Feb 10, 2023
Closed
@ajstorm ajstorm added the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Mar 7, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 7, 2023

Hi @ajstorm, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@ajstorm ajstorm added the branch-master Failures and bugs on the master branch. label Mar 7, 2023
@knz knz removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Mar 13, 2023
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jun 30, 2023
@knz knz removed the T-server-and-security DB Server & Security label Jun 30, 2023
@rafiss rafiss mentioned this issue Jul 7, 2023
Merged
@rafiss rafiss assigned rafiss and unassigned ecwall Jul 7, 2023
craig bot pushed a commit that referenced this issue Jul 8, 2023
@rafiss
Merge #106463
43c26ae 
106463: interactive_tests: preserve demo logs in tests r=knz a=rafiss

Now we pass in the --log-dir option so that logs are saved when the test fails. Otherwise, the demo command does not log.

This also unskips two tests that should be working now.

informs #96450
informs #102257
informs #100319
informs #106462
informs #106461
informs #96797
informs #96239


Release note: None

Co-authored-by: Rafi Shamim <[email protected]>
@rafiss
Copy link
Collaborator

rafiss commented Jul 8, 2023

#106463 unskips this and also fixes the logging. So if this flakes again, at least we can investigate it.

@rafiss rafiss closed this as completed Jul 8, 2023
@rafiss rafiss mentioned this issue Jul 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). skipped-test T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@knz @rafiss @ecwall @adityamaru @ajstorm @msbutler