sql/tests: TestRandomSyntaxGeneration failed #95908
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
GA-blocker
O-robot
Originated from a bot.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
Comments
cockroach-teamcity
added
branch-master
blathers-crl
bot
added
the
T-sql-foundations
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 95a3a11f11b09481bbdf56820eea4420120f04f9: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 78fe59d0536be35fcec68280142746fb91515551: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 69dd453d0e61e258f402c5751de310405743cd18: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 69dd453d0e61e258f402c5751de310405743cd18: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 1fb7236f7b1f53e28bde833c28bed83a976138cf: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ b59fa09d971e92b8b5bcc874437159ef252e0313: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 22244a780dcfaca48162dde8e0f90b5ba9b6bb9c: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 44d9f3c8b7bd46839187cea69eaec640c080ac05: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 5fbcd8a8deac0205c7df38e340c1eb9692854383: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 8e24570fa366ed038c6ae65f50db5d8e22826db0: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 8e24570fa366ed038c6ae65f50db5d8e22826db0: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ eb158026c50d8fa856e42f928d844831ea9e6b28: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ ff67a4ba86d710db090ce700f229020365851183: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 09188370d82e163ff1d44c62fe611104502c548d: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ e51ffa013c81212870891001f0328912550fa75d: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 2a7edbeb0737b1309064c25c641a309c2980d9ba: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 2a7edbeb0737b1309064c25c641a309c2980d9ba: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 2a7edbeb0737b1309064c25c641a309c2980d9ba: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 31365e21dc606cdc1e4302c86192ffc5a6cf1255: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 64a867acd25c0a214209957eefb6483d1158b4f0: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ a0ab818e89508ca0b65926a4faac4c563d114acf: Random syntax error: Query: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 7e2df35a2f6bf7a859bb0539c8ca43c4e72ed260: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ c95bef097bd4c213c6b5c0c125a9a846c4479d73: Same failure on other branches
|
|
I'm labelling this a GA-blocker. There's a number of panics reported that I'm assuming would crash a node. |
|
I've been unable to repro using |
|
The last one seems to be related to the new COPY TO support, basically COPY BLAH TO STDOUT runs "BLAH" in an internal executor and if the query starts with EXPLAIN we can hit the unimplemented panic b/c internal executor uses a streamingCommandResult which doesn't support ResetStmtType. I couldn't repro with a some basic tries. @otan got an ideas on what might be going on here? Do we need to do some of allow listing of what kinds of subqueries COPY TO supports? |
|
we don't do any allowlisting at the moment, so in theory it's anything the parser says it can support. if it's an issue with COPY TO dare i say it may be an issue with DECLARE CURSOR, because i think we use the same logic? |
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 10c1e3e01b7da4cced0478e1bfd711a1c9be9afc: Same failure on other branches
|
|
Repro: |
|
If I comment out the panic("unimplemented") I get: Not sure if this is correct output. I think I'll wait for SQL Sessions to opine before I do anything else. |
|
hmm, Weird, that probably means PreparableStmt in PG doesn't include EXPLAIN (https://github.com/postgres/postgres/blob/master/src/backend/parser/gram.y#L3319), but CRDB does ( cockroach/pkg/sql/parser/sql.y Line 3966 in 7f2afbc |
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 9b43dc50d468171bc9919dc684b7274b63e13da2: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ d68f5cdfb25476aaf874bff0bb6515eba02efcd2: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ f0489334a0ee6980a9d365b361d2fce4b2cdc05b: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 6c99966f604f3521acdb925b9f689529ffd46df3: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 53dbb86acb1d48309530181b94838faf937084d3: Same failure on other branches
|
craig bot
pushed a commit
that referenced
this issue
Mar 19, 2023
98326: cluster-ui: move table details endpoint to use sql-over-http r=maryliag a=THardy98 Part of: #89429 Addresses: #90264, #90268 This PR migrates our existing admin API table details endpoint to use sql-over-http in cluster-ui. We change the structure of the table details response, allowing each field to be a self-contained query response. The exception here is the `stats` field, which is comprised of a couple query responses. Changing the structure scopes errors at the query-level, instead of the response level. This is important as it allows us to still make use of partial data on the UI when only a subset of the queries succeed. The commit also coalesces the former table stats and table details API into a single table details API. The only difference/movement here is that the table details endpoint now fetches span statistics. The data for table details is populated using 10 queries, which fetch the table's: - ID - grants - schema details (columns & indexes) - create statement - zone configuration statement - zone configuration - heuristics details (specifically, the timestamp at which table heuristics were last updated) - span statistics - index usage statistics - replicas This largely reflects like for like how we fetch data from the existing admin api endpoint. We can improve upon this (i.e. remove bloating) in follow up PRs. **Short Demo** https://www.loom.com/share/698c10c5752e439a9edb0ec2301771c1 Release note: None 98977: sql/parser: fix the numeric tenant_spec grammar r=cucaroach a=knz Informs #95908. Epic: CRDB-23559 Release note: None Co-authored-by: Thomas Hardy <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 9acc75317aebfdfe69fb097a8a28e0040c7a67fd: Same failure on other branches
|
|
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ b89fa2cc4bc1fb9447ab1009b34b6f354f9618f0: Same failure on other branches
|
|
I believe most of these issues are fixed now with #98821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 2ad8df3df3272110705984efc32f1453631ce602:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
This test on roachdash | Improve this report!
Jira issue: CRDB-23808
The text was updated successfully, but these errors were encountered: