You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The transaction insight details page in the CC console hangs indefinitely on refresh.
When selectTxnInsightDetailsCombiner (a selector called when the transaction insight details page is loaded) returns null, a refresh is triggered.
In the case of transaction insight detail events of type "High Contention" (i.e., every time you navigate to the details page of a High Contention insight event), a refresh will always be triggered, as selectTxnInsightDetailsCombiner will always return null when the transactionInsightDetails.cachedData is in its initial empty state.
As shown in the loom video, in the case of all other transaction detail events where type != "High Contention", selectTxnInsightDetailsCombiner returns the insights data cached in the executionInsights and transactionInsights slices when you navigate to the details page from the overview page. However, on a manual refresh, the page hangs indefinitely.
I'm not exactly sure why this is happening, but the browser console errors point to a "MapSet" error. I interpreted this as an issue with the initial state of transactionInsightDetails.cachedData (populated using new Map()), and was able to resolve the error by changing the cachedData type from a map to an object with an initial state of {}. This is how we've been typing/initializing other "map"-like slices (e.g., statement details).
I'm not exactly sure why this is happening, but the browser console errors point to a "MapSet" error. I interpreted this as an issue with the initial state of transactionInsightDetails.cachedData (populated using new Map()), and was able to resolve the error by changing the cachedData type from a map to an object with an initial state of {}. This is how we've been typing/initializing other "map"-like slices (e.g., statement details).
I'm going to add this temporary fix to #92285, as I see it as an additional blocker for #83780.
This commit reverts the cachedData field of
TransactionInsightDetailsCachedState from a map to an object.
Fixescockroachdb#94380 in release-22.2.
Release note: None
The transaction insight details page in the CC console hangs indefinitely on refresh.
When
selectTxnInsightDetailsCombiner
(a selector called when the transaction insight details page is loaded) returnsnull
, a refresh is triggered.In the case of transaction insight detail events of type "High Contention" (i.e., every time you navigate to the details page of a High Contention insight event), a refresh will always be triggered, as
selectTxnInsightDetailsCombiner
will always returnnull
when thetransactionInsightDetails.cachedData
is in its initial empty state.Here's a loom demonstrating that scenario: https://www.loom.com/share/8dce9d06ae2548b2adf5fc38831f790f
As shown in the loom video, in the case of all other transaction detail events where type != "High Contention",
selectTxnInsightDetailsCombiner
returns the insights data cached in theexecutionInsights
andtransactionInsights
slices when you navigate to the details page from the overview page. However, on a manual refresh, the page hangs indefinitely.I'm not exactly sure why this is happening, but the browser console errors point to a "
MapSet
" error. I interpreted this as an issue with the initial state oftransactionInsightDetails.cachedData
(populated usingnew Map()
), and was able to resolve the error by changing the cachedData type from a map to an object with an initial state of{}
. This is how we've been typing/initializing other "map"-like slices (e.g., statement details).Here's another loom demonstrating the error on management staging: https://www.loom.com/share/fec151a3a39f4a469c1efd0bc8fec54b
Jira issue: CRDB-22864
The text was updated successfully, but these errors were encountered: